-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP support with foundation for PHP libraries to load third parties #40
Conversation
@felixarntz - this looks great so far! the main possible improvement would be adding tests although I'm not sure that should be a blocker since the JS side doesn't have them :) |
It's always great to have a new set of eyes on the JS side as well 😄 |
@housseindjirdeh @adamsilverstein @flashdesignory I've completed the remaining tests so this is now ready for full review. Regarding documentation, for now I only added a small note to the readme referring to both the JS and PHP implementations. More wasn't really needed at this point, as everything else in the readme applies in both scenarios. I think it would be useful to add more specific documentation (most importantly a few code examples in both JS and PHP), but that could be done in a separate PR. |
@housseindjirdeh @adamsilverstein @flashdesignory Friendly ping :) Any chance we can get this merged in the next 1-2 weeks? |
Fixes #39
Move JSON files out of JS-specific folders(will be done in a follow up PR)